fix: log explicit messages when bootstrap.dcs.standby_cluster can't parse#108
Open
vlsi wants to merge 1 commit intoNetcracker:mainfrom
Open
fix: log explicit messages when bootstrap.dcs.standby_cluster can't parse#108vlsi wants to merge 1 commit intoNetcracker:mainfrom
vlsi wants to merge 1 commit intoNetcracker:mainfrom
Conversation
Collaborator
|
Hi, thank you, this looks right to handle each field separately. However we have to follow the old logic and stop execution if one of the fields incorrect or not found. So here we have to send the error and stop reconcile. |
…arse Return errors from updateStandbyClusterSettings and propagate them to the reconciler so that reconciliation stops on invalid config instead of silently continuing with an unmodified configmap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vlsi
force-pushed
the
bootstrap_dcs_logs
branch
from
cbf405d to
966ae9e
Compare
Collaborator
Author
|
@Tvion , right you are. I've updated the code so it returns the error. Could you review again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a generic panic was logged, so it was hard to figure out the cause